fix: don't fail release jobs when gh CLI is missing on the runner - #5344
Merged
Conversation
fusion-gh-runner-fusion-framework doesn't have the GitHub CLI installed, so the 'convert Changeset PR to draft' step in ci.yml and next.yml was failing with 'gh: command not found'. Marked non-blocking with continue-on-error until the runner image is fixed (tracked with infra) — worst case the changeset PR just stays open/ready instead of draft.
|
github-actions
Bot
added
🐞 bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why is this change needed?
The
fusion-gh-runner-fusion-frameworkself-hosted runner doesn't have the GitHub CLI (gh) installed. This broke the "convert Changeset PR to draft" step inci.yml'srelease-pkgjob on the last run (gh: command not found, exit 127): https://github.com/equinor/fusion-framework/actions/runs/32279766760/job/96155504260. The same step exists innext.yml'srelease-pkgjob on the same runner label.What is the current behavior?
Both steps hard-fail the whole job when a changeset PR needs converting to draft, blocking the release/pre-release workflow entirely.
What is the new behavior?
Both steps are now
continue-on-error: true. Worst case, the changeset PR just stays open/ready instead of being converted to draft — non-blocking.What is the intended behavior or invariant?
This is a stopgap. Infra has been notified separately to install
ghon thefusion-gh-runner-fusion-frameworkrunner image; once that's done, these steps will succeed again as before andcontinue-on-errorbecomes a no-op safety net rather than the primary fix.Does this PR introduce a breaking change?
No.
Impact assessment:
Review guidance:
Confirmed via job log that
ghis genuinely absent on this runner (not a transient issue), and that these are the only twogh-CLI-consuming steps running onfusion-gh-runner-fusion-frameworkin the whole workflow set (other jobs on that runner don't callgh; other workflows that do callghrun onubuntu-latest, which ships it).Additional context
None.
Related issues
None.
Checklist